https://projects.ecoinformatics.org/ecoinfo/https://projects.ecoinformatics.org/ecoinfo/ecoinfo/favicon.ico?14691340362012-08-30T03:29:34ZEcoinformatics RedmineKepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=196042012-08-30T03:29:34ZChristopher Brookscxh@eecs.berkeley.edu
<ul></ul><p>I'm reassigning this to Dan.</p>
<p>There has to be a better way to do this than to duplicate a bunch of code.</p> Kepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=196052012-09-20T23:26:17ZDaniel Crawldanielcrawl@gmail.com
<ul></ul><p>One solution is to move as much of the duplicated code as possible into static methods. There would still need to be CaseGraphFrame and CaseGraphTableau classes in Kepler, but they would be small.</p>
<p>Another solution is for KeplerGraphFrame to become a subclass of CaseGraphFrame. CaseGraphFrame would have to be updated to display a tabbed pane and create menus for adding/removing refinements only if the container was a Case actor.</p>
<p>Both solutions remove a lot of the duplicated code but do not really fix the problem... Comments? Other solutions?</p> Kepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=196062012-09-21T04:38:32ZChristopher Brookscxh@eecs.berkeley.edu
<ul></ul><p>One option would be to move more of the KeplerGraphFrame features in to BasicGraphFrame.</p>
<blockquote>
<p>CaseGraphFrame would have to be updated to display a tabbed pane and create <br />menus for adding/removing refinements only if the container was a Case actor.</p>
</blockquote>
<p>KeplerGraphFrame has tabs that appear in the right pane, but these tabs are not visible when I run kepler. Where do the tabs appear?<br />Can more of KeplerGraphFrame be merged into BasicGraphFrame?</p>
<p>One issue is that KeplerGraphFrame has scrollbars. Could these be disabled<br />for Vergil?</p>
<p>KeplerGraphFrame also has a save as that saves the kar files.</p>
<p>Maybe we can use some sort of mixin facility?</p>
<p>See<br /><a class="external" href="http://stackoverflow.com/questions/386695/option-for-inheritance">http://stackoverflow.com/questions/386695/option-for-inheritance</a></p> Kepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=196072013-03-27T21:31:15ZRedmine Admin
<ul></ul><p>Original Bugzilla ID was 5659</p> Kepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=222512015-08-17T01:35:30ZDaniel Crawldanielcrawl@gmail.com
<ul><li><strong>Target version</strong> changed from <i>2.5.0</i> to <i>2.X.Y</i></li></ul><p>CaseGraphFrame is no longer in Kepler. CaseGraphTableau still is.</p> Kepler - Bug #5659: Kepler CaseGraphFrame and CaseGraphTableau have duplicated Ptolemy code.https://projects.ecoinformatics.org/ecoinfo/issues/5659?journal_id=222542015-08-17T15:10:46ZChristopher Brookscxh@eecs.berkeley.edu
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>I'm not sure of the status of this bug.</p>
<p>There is a CaseGraphTableau in ptII and kepler/gui and a CaseGraphFrame in ptII:</p>
<p>./gui/src/org/kepler/gui/frame/CaseGraphTableau.java<br />./ptolemy/src/ptolemy/vergil/modal/CaseGraphFrame.java<br />./ptolemy/src/ptolemy/vergil/modal/CaseGraphTableau.java</p>
<p>There was a CaseGraphFrame in Kepler, but that was removed.</p>
<p>The duplicate code check for Kepler no longer shows a problem here, see <a class="external" href="http://terra.eecs.berkeley.edu:8080/job/kepler/Kepler_Duplicate_Code/">http://terra.eecs.berkeley.edu:8080/job/kepler/Kepler_Duplicate_Code/</a></p>
<p>I'm closing this bug.</p>