/src/edu/ucsb/nceas/metacat/accesscontrol/XMLAccessAccess.java - Diff - Metacat - Ecoinformatics Redmine

« Previous | Next »

Revision 5108

Added by daigle over 14 years ago

move dbconnection object out of base class and create it for each db access so it can be released

     	private Logger logMetacat = Logger.getLogger(XMLAccessAccess.class);
     	// Constructor
     	public XMLAccessAccess() throws AccessException {
     		super("XMLAccessAccess");
+    	}
     	public XMLAccessAccess() throws AccessException {}
     	/**
     	 * Get all xml access for a document
-...
     		// first get the job from the db and put it into a DAO
     		PreparedStatement pstmt = null;
     		try {
     		DBConnection conn = null;
     		int serialNumber = -1;
     		try {
     			conn = DBConnectionPool.getDBConnection("XMLAccessAccess.getXMLAccessForDoc");
         		serialNumber = conn.getCheckOutSerialNumber();
     			String sql = "SELECT * FROM xml_access WHERE docid = ?";
     			pstmt = conn.prepareStatement(sql);
-...
     			logMetacat.error(errorStr);
     			throw new AccessException(errorStr);
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.getXMLAccessForDoc - An error occurred "
     						+ "closing prepared statement: " + sqle.getMessage());
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     		// first get the job from the db and put it into a DAO
     		PreparedStatement pstmt = null;
     		DBConnection conn = null;
     		int serialNumber = -1;
     		try {
     			conn = DBConnectionPool.getDBConnection("XMLAccessAccess.getXMLAccessForPrincipal");
         		serialNumber = conn.getCheckOutSerialNumber();
     			String sql = "SELECT * FROM xml_access WHERE docid = ? AND principal_name = ?";
     			pstmt = conn.prepareStatement(sql);
-...
     			logMetacat.error(errorStr);
     			throw new AccessException(errorStr);
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.getXMLAccessForPrincipal - An error occurred "
     						+ "closing prepared statement: " + sqle.getMessage());
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     		// first get the job from the db and put it into a DAO
     		PreparedStatement pstmt = null;
     		DBConnection conn = null;
     		int serialNumber = -1;
     		try {
     			conn = DBConnectionPool.getDBConnection("XMLAccessAccess.getXMLAccessForPrincipal");
         		serialNumber = conn.getCheckOutSerialNumber();
     			String sql = "SELECT * FROM xml_access WHERE docid = ? AND principal_name = ? " +
     				"AND perm_type = ? AND perm_order = ?";
     			pstmt = conn.prepareStatement(sql);
-...
     			logMetacat.error(errorStr);
     			throw new AccessException(errorStr);
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.getXMLAccessForPrincipal - An error occurred "
     						+ "closing prepared statement: " + sqle.getMessage());
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     	 *            permission order
     	 */
     	public void addXMLAccess(String docId, String principalName, Long permission, String permType,
     			String permOrder) throws AccessException {
     			String permOrder) throws AccessException, PermOrderException {
     		permOrderConflict(docId, permOrder);
     		Vector<XMLAccessDAO> xmlAccessList =
     			getXMLAccessForPrincipal(docId, principalName, permType, permOrder);
-...
+    		}
     		XMLAccessDAO xmlAccessDAO = xmlAccessList.get(0);
     		// if the permission on the xml access dao does not already contain the permission we are
     		//trying to add, update the access record with the existing permission bitwis OR-ed with our
     		// new permission
-...
     	 * @param xmlAccessList
     	 *            list of xml access dao objects that hold new access for the document
     	 */
     	public void setXMLAccess(String docId, Vector<XMLAccessDAO> xmlAccessList) throws AccessException {
     	public void replaceAccess(String docId, Vector<XMLAccessDAO> xmlAccessList) throws AccessException {
     		deleteXMLAccessForDoc(docId);
     		// if more than one record exists for this principal on this document with the same
-...
     					+ "xml access permissions for doc id: " + docId + ", principal: " +
     					principalName + ":" + sqle.getMessage());
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.insertXMLAccess - SQL error when closing prepared " +
     						"statement after inserting xml access permissions for doc id: " + docId +
     						", principal: " +  principalName + ":" + sqle.getMessage());
     			} finally {
     				DBConnectionPool.returnDBConnection(conn, serialNumber);
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     					+ "xml access permissions for doc id: " + docId + ", principal: " +
     					principalName + ":" + sqle.getMessage());
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.updateXMLAccessPermission - SQL error when closing prepared " +
     						"statement after updating xml access permissions for doc id: " + docId +
     						", principal: " +  principalName + ":" + sqle.getMessage());
     			} finally {
     				DBConnectionPool.returnDBConnection(conn, serialNumber);
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     			throw new AccessException("XMLAccessAccess.deleteXMLAccessForDoc - SQL error when deleting"
     					+ "xml access permissions for doc id: " + docId + ":" + sqle.getMessage());
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.deleteXMLAccessForDoc - SQL error when closing prepared " +
     						"statement after deleting xml access permissions for doc id: " + ":" + sqle.getMessage());
     			} finally {
     				DBConnectionPool.returnDBConnection(conn, serialNumber);
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     					+ "xml access permissions for doc id: " + docId + ", principal: " +
     					principalName + ":" + sqle.getMessage());
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.deleteXMLAccessForPrincipal - SQL error when closing prepared " +
     						"statement after deleting xml access permissions for doc id: " + docId +
     						", principal: " +  principalName + ":" + sqle.getMessage());
     			} finally {
     				DBConnectionPool.returnDBConnection(conn, serialNumber);
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
-...
     	 * @param principal
     	 *            principal credentials
     	 */
     	private void permOrderConflict(String docId, String permOrder) throws AccessException, PermOrderException {
     		if (docId == null) {
     			throw new AccessException("XMLAccessAccess.permOrderConflict - docid is required when " +
     					"determining perm order conflict");
+    		}
     		if (permOrder == null) {
     			throw new AccessException("XMLAccessAccess.permOrderConflict - perm order is required when " +
     					"determining perm order conflict");
+    		}
     	    PreparedStatement pstmt = null;
     		DBConnection conn = null;
     		int serialNumber = -1;
     		try {
     			// check out DBConnection
     			conn = DBConnectionPool.getDBConnection("XMLAccessAccess.permOrderConflict");
     			String sql = "SELECT * FROM xml_access WHERE docid = ? AND perm_order != ?";
     			pstmt = conn.prepareStatement(sql);
     			// Bind the values to the query
     			pstmt.setString(1, docId);
     			pstmt.setString(2, permOrder);
     			String sqlReport = "XMLAccessAccess.permOrderConflict - SQL: " + sql;
     			sqlReport += " [" + docId + "," + permOrder + "]";
     			logMetacat.info(sqlReport);
     			pstmt.execute();
     			ResultSet resultSet = pstmt.getResultSet();
     			if (resultSet.next()) {
     				throw new PermOrderException("XMLAccessAccess.addXMLAccess - cannot add permission " +
     					"record for doc id: " + docId + "with permOrder: " + permOrder + " due to permOrder conflict");
+    			}
     		} catch (SQLException sqle) {
     			throw new AccessException("XMLAccessAccess.permOrderConflict - SQL error when checking"
     					+ "for perm order conflict on: " + docId + ":" + sqle.getMessage());
     		} finally {
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}
     	/**
     	 * Delete xml access.  This removes all access records from the database for a principal
     	 * for a given document, perm type and perm order
     	 * @param docId
     	 *            document id
     	 * @param principal
     	 *            principal credentials
     	 */
     	private void deleteXMLAccessForPrincipal(String docId, String principalName, String permType, String permOrder) throws AccessException {
     		if (docId == null) {
     			throw new AccessException("XMLAccessAccess.deleteXMLAccessForPrincipal - docid is required when " +
-...
     		try {
     			// check out DBConnection
     			conn = DBConnectionPool.getDBConnection("XMLAccessAccess.deleteXMLAccessForPrincipal");
     			String sql = "DELETE FROM xml_access WHERE docid = ? AND principal_name = ?" +
     				"AND perm_type = ? AND perm_ord";
     			String sql = "DELETE FROM xml_access WHERE docid = ? AND principal_name = ? " +
     				"AND perm_type = ? AND perm_order = ?";
     			pstmt = conn.prepareStatement(sql);
     			// Bind the values to the query
-...
     					+ "xml access permissions for doc id: " + docId + ", principal: " +
     					principalName + ":" + sqle.getMessage());
     		} finally {
     			try {
     				if (pstmt != null) {
     					pstmt.close();
+    				}
     			} catch (SQLException sqle) {
     				logMetacat.error("XMLAccessAccess.deleteXMLAccessForPrincipal - SQL error when closing prepared " +
     						"statement after deleting xml access permissions for doc id: " + docId +
     						", principal: " +  principalName + ":" + sqle.getMessage());
     			} finally {
     				DBConnectionPool.returnDBConnection(conn, serialNumber);
+    			}
     			closeDBObjects(pstmt, conn, serialNumber, logMetacat);
+    		}
+    	}

Also available in: Unified diff

Project

General

Profile

Metacat

Revision 5108

Added by daigle over 14 years ago