Metacat

In registerSystemMetadata(), lock the pid prior to calling map.containsKey(pid) since a put to the map could occur between the check and the subsequent put().

Use Lock instead of ILock to be consistent across classes.

After reviewing CNodeService and D1NodeService prompted by Robert comparing the Hazelcast locking with the d1_synchronization locking, I've made a number of changes that will prevent locking problems:

1) Multiple methods contained try/catch blocks that would:...

use inherited access control from EML for the data file we download from a remote source
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5522

download remote data and save locally when it is referenced by an EML package, then include it in the ORE map.
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5522

exapnd permissions on the exisiting access rule not on the permission being checked. (hierarchical permissions)

Make sure the local id isn't null when we try to get the object from the local instance.

Simplify the error handling, and throw the exception once the CN is updated with the new status.

Set the replica status to failed (not invalidated) when we get exceptions trying to read the object bytes. Not much of a difference, but only the CN, in theory, is supposed to be able to set the invalidated status.

Set the replication status to invalidated when we have a localId, but getting the object bytes fails for any reason.