Project

General

Profile

Bug #3853

Make sure the sbclter and pisco skins work with token replacement

Added by Michael Daigle over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Category:
metacat
Target version:
Start date:
03/02/2009
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
3853

Description

Work with Margaret to knock out the remaining display issues on the sbclter skin.

History

#1 Updated by Michael Daigle over 10 years ago

Email I sent to metacat developers:

I had to make a few changes to the way the sbclter skin works, mostly because the style/shared/eml-2.0.0/eml.xsl file tries to import files from the skins directories. This worked when we used token replacement, but doesn't work with variables.
I will need to make similar changes to the pisco skin to make that work, so Chris, can you take a look at what I've done for sbclter and let me know if it's okay to make the same changes to pisco?

What I've done:

-- Created a style/shared/eml-2.1.0 directory that is a copy of the eml-2.0.0 directory (needs to be updated for 2.1.0)
-- Created style/skins/sbclter/templates/xsl/sbclter-eml-2.0.0.xsl and sbclter-eml-2.1.0.xsl which do local includes
and header template calls and import the shared eml.xsl files.
-- Pointed /style/skins/sbclter/sbclter.xml to the appropriate sbclter-eml-2.X.X.xsl file

What I propose for the new EML-UTIL module that we will create post release:

-- Rename the /style/shared directory to /style/common-css-layout
-- move the /style/common-css-layout code into the EML-UTIL module in svn (tag 2.0.0 code with old tags)
-- check out the common-css-layout from EML-UTIL at metacat build time (like we do now for common)
-- Rename the /style/common directory in EML-UTIL to /style/common-table-layout
-- If needed, extract any truly shared generic code from /style/common-X-layout directories into a shared directory.

#2 Updated by Michael Daigle over 10 years ago

Updated the SBCLTER skins with margaret. Chris said to leave pisco. They would make it work with an existing skin.

#3 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 3853

Also available in: Atom PDF