Project

General

Profile

« Previous | Next » 

Revision 6606

Added by ben leinfelder over 12 years ago

uses prepared statement instead of plain old statement.
deprecated the DBConnection.createStatement() method to discourage direct parameter value use in favor of parameter binding.
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5527

View differences:

EML201DocumentCorrector.java
1 1 
package edu.ucsb.nceas.metacat;
2 2 

  		




  3
  
  
    
import java.sql.Statement;


  		




  
  3
  
    
import java.sql.PreparedStatement;


  		




  4
  4
  
    

  		




  5
  5
  
    
import org.apache.log4j.Logger;


  		




  6
  6
  
    

  		




  ......




  50
  50
  
    
    	           //checkout the dbconnection


  		




  51
  51
  
    
    	          dbconn = DBConnectionPool.getDBConnection("EML201DocumentCorrector.run");


  		




  52
  52
  
    
    	          serialNumber = dbconn.getCheckOutSerialNumber();


  		




  53
  
  
    
    	          Statement deletingStatement = dbconn.createStatement();


  		




  
  53
  
    
    	          PreparedStatement deletingStatement = null;


  		




  54
  54
  
    
    	         


  		




  55
  55
  
    
    	          // delete the records in xml_index table 


  		




  56
  56
  
    
    	          String deletingIndex = generateXML_IndexDeletingSQL();


  		




  57
  57
  
    
    	          logMetacat.debug("EML201DocumentCorrector.run - deleting the records in xml_index table with sql: " + deletingIndex);


  		




  58
  
  
    
    	          deletingStatement.execute(deletingIndex);


  		




  
  58
  
    
    	          deletingStatement = dbconn.prepareStatement(deletingIndex);


  		




  
  59
  
    
    	          deletingStatement.execute();


  		




  
  60
  
    
    	          deletingStatement.close();


  		




  59
  61
  
    
    	          


  		




  60
  62
  
    
    	          // delete the records in xml_nodes table


  		




  61
  63
  
    
    	          String deletingNode = generateXML_NodeDeletingSQL();


  		




  62
  64
  
    
    	          logMetacat.debug("EML201DocumentCorrector.run - deleting the records in xml_nodes table with sql: " + deletingNode);


  		




  63
  
  
    
    	          deletingStatement.execute(deletingNode);


  		




  
  65
  
    
    	          deletingStatement = dbconn.prepareStatement(deletingNode);


  		




  
  66
  
    
    	          deletingStatement.execute();


  		




  
  67
  
    
    	          deletingStatement.close();


  		




  64
  68
  
    
    	          


  		




  65
  69
  
    
    	          // delete the records in xml_nodes_revisions table


  		




  66
  70
  
    
    	          String deletingNodeRevision = generateXML_Node_RevisionsDeletingSQL();


  		




  67
  71
  
    
    	          logMetacat.debug("EML201DocumentCorrector.run - deleting the records in xml_nodes_revisions table with sql: " + deletingNodeRevision);


  		




  68
  
  
    
    	          deletingStatement.execute(deletingNodeRevision);


  		




  
  72
  
    
    	          deletingStatement = dbconn.prepareStatement(deletingNodeRevision);


  		




  
  73
  
    
    	          deletingStatement.execute();


  		




  
  74
  
    
    	          deletingStatement.close();


  		




  69
  75
  
    
    	          


  		




  70
  
  
    
    	          //close statement and connection


  		




  71
  
  
    
    	          deletingStatement.close();


  		




  72
  
  
    
    	          //dbconn.close();


  		




  73
  76
  
    
    	          success = true;


  		




  74
  77
  
    
    	      }


  		




  75
  78
  
    
    	        catch (Exception ee)


  		












Also available in:  Unified diff