Bug #4419
closedKARFile openKARContents problem with open success
0%
Description
If WorkflowRun KAREntryHandler open method returns true, KARFile openKARContents gives an error. It looks like all entryhandler opens are returning false (why is actormetadata handler never returning true? i'm guessing this is just by mistake -- fixing this would be a good test).
java.lang.Exception: Error on Open: null
at org.kepler.kar.KARFile.openKARContents(KARFile.java:528)
at org.kepler.gui.kar.OpenArchiveAction.openKAR(OpenArchiveAction.java:153)
I've been trying to spot the problem for quite awhile now but am failing...sorry, either tired eyes, or something difficult to find. My preference now is to just rewrite that method rather than keep trying to find the bug, so I'm filing this instead in case you (Aaron) want to keep it this way or if it's still under construction (e.g. the dependency list stuff). If you want me to try a rewrite just let me know...
Updated by Aaron Aaron over 14 years ago
I modified ActorMetadataKAREntryHandler to return true upon successfully opening a workflow. This may help. Also the dependency algorithm implemented in KARFile.openKARContents() is not well tested yet. Make sure your KAREntry has the appropriate lsidDependencies specified in the manifest.
Updated by Derik Barseghian over 14 years ago
The problem was some missing break statements in KARFile's openKARContents, fixed in r20815. I'll close this bug once I do some more testing and get the problem with WorkflowRun's not opening fixed...
Updated by Derik Barseghian over 14 years ago
Have tested more, and this bug seems fixed. There are a few other problems related to opening kar's, but I'll open different bugs for those.