Project

General

Profile

Bug #4539

Applying a tag can be slow

Added by Derik Barseghian over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Category:
tagging
Target version:
Start date:
11/09/2009
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
4539

Description

I've tracked down (one of?) the reason(s) for applying a tag being slow -- starting at the Workflow Run Manager a call is eventually made to SQLQueryV8's getTagClassesForExecutionLSID, and the call therein to NamedOntClass.createNamedOntClassFromURIs(tagURI, ontologyURI) is the expensive part, it takes about 260ms. Sean do you know if that method can easily be sped up? An alternative might be to only (look up and) set a WorkflowRun's tags member variable right before it's really needed, but this feels a little less clean.

History

#1 Updated by Derik Barseghian over 9 years ago

See comment in r21462.

#2 Updated by Derik Barseghian over 9 years ago

Fixed in r21473. Problem was repeated calls to Vector contains() in NamedOntModel.getNamedClasses() which is expensive. Changed to a TreeSet so contains() calls are faster and sorting is free.

#3 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 4539

Also available in: Atom PDF