Project

General

Profile

Bug #4544

Enter key in Report Designer title invokes a search

Added by Derik Barseghian over 9 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
reporting
Target version:
Start date:
11/13/2009
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
4544

Description

I notice if I enter a title in the Report Designer and then hit Enter, I get debug messages on the console from ComponentLibraryTab SearchButtonActionHandler actionPerformed -- it looks like a search with blank search term happens. When I go back to the Workflow tab, my components pane hasn't changed at all, so this doesn't seem too bad...but definitely odd.

History

#1 Updated by debi staggs almost 9 years ago

This is no longer happening for me.

#2 Updated by Derik Barseghian almost 9 years ago

This still happens for me on trunk, on mac and windows. A way to replicate that shows in the gui:
Type sdf into the Search Components field, and don't hit enter.
Go to the Report Designer, type a title into the title area, and hit enter.
Go back to the Workflow Editor view to see the search results for sdf displayed.

#3 Updated by debi staggs almost 9 years ago

I have looked at this again, and following the steps you describe, I can see this in the GUI. However, I don't think it is really a problem in any way, just a bit odd as you have said in your previous comment. But not enough to hold up the release or impair any functionality as far as I can tell. Can we agree to postpone this or close this bug for now ?

#4 Updated by Derik Barseghian almost 9 years ago

No need to change anything on this bug IMO, it was filed with Importance 'minor' and targeted for 2.X.Y.

#5 Updated by ben leinfelder almost 9 years ago

This shouldn't be that hard to fix. It actually sounds like the search field is being greedy. Can the KeyEventListener that I imagine is added to the search field only perform it's search if it has current focus

#6 Updated by Derik Barseghian about 8 years ago

Retargeting, I want this fixed.

#7 Updated by Derik Barseghian about 8 years ago

fixed at r26896. This took awhile to track down. Turns out the searchButton was the set defaultButton for the jRootPane, and that's why it was hearing Enters from places we didn't expect. This is also why the search button always pulsed blue on the mac, hope no one was fond of that.
"Most look and feels render the default button differently, and may potentially provide bindings to access the default button."
I commented that out, and set the textfield's action to the searchAction.

#8 Updated by Redmine Admin almost 6 years ago

Original Bugzilla ID was 4544

Also available in: Atom PDF