Bug #5015
closedExport of runs contain different, and missing or extra reporting items now
0%
Description
After the changes to roll ROML lsids with changes, the first export of a run kar contains less items than the second export of the same run. The first export no longer contains the RIOs, and the second export contains an extraneous ROML. An example export of a run from WRM:
1st export:
derik_test_wf_with_report_ROML.xml
derik_test_wf_with_report.urn.lsid.kepler-project.org.ns..1079.1.11.xml
WorkflowRun.1.xml
2nd export:
derik_test_wf_with_report_ROML.xml
ROML.1.xml
derik_test_wf_with_report.urn.lsid.kepler-project.org.ns..1079.1.11.xml
RIO.1.pdf
RIO.1.xml
WorkflowRun.1.xml
I don't think either of these contains the right items -- it used to be that you only get 1 ROML, so the second kar contents minus a ROML would seem right to me.
Updated by Derik Barseghian over 14 years ago
Partially fixed. Now, when exporting a run kar from WRM, you'll consistently get items like in "2nd export" listed above. So now just need to avoid adding the extra ROML - ie workflowname_ROML.xml.
Updated by Derik Barseghian over 14 years ago
Essentially fixed in r24492 (trunk) and 24495 (2.0).
Now utilizing wrm.getSelectedRows to see if the save is for in "run context" -- if so, don't call saveReportLayout for the workflow, thus avoiding (the new) problem of trying to put 2 ROMLs with the same lsid but different names in the same KAR. This problem was especially problematic because the ROML that depended on the run could be the one not added due to the lsid-uniqueness constraint, and this now has ramifications when trying to import the run (no roml would be added to provenance and thus couldn't show in the report designer).
I believe only issue left here is a minor one -- a e.g. "workflow_roml.xml" in one kar may have the same lsid as a e.g. "roml.1.xml" in another kar, and the components tree will show both using only one name, when in fact the filenames are different. This may confuse a user who views a manifest and sees a roml name not matching up with what's shown in the components tree.
Updated by Derik Barseghian over 14 years ago
Closing, opened bug#5018 for issue described above.