Project

General

Profile

Bug #5290

originModule not always set

Added by Daniel Crawl over 8 years ago. Updated about 4 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
core
Target version:
Start date:
02/02/2011
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5290

Description

The <originModule> property is added to configuration files so that properties will be ignored when their originating module is not loaded. However, sometimes <originModule> is not set. For example:

ant change-to -Dsuite=reporting
ant run
ant change-to -Dsuite=fault-tolerance
ant run
ant change-to -Dsuite=kepler
ant run

Results in:

[run] java.lang.ClassNotFoundException: org.kepler.reporting.gui.ItemsOfInterestPanel$Factory

In ~/KeplerData/modules/gui/configuration/configuration.xml, the <tabPane> for Items Of Interest does not have <originModule>.

History

#1 Updated by Derik Barseghian almost 8 years ago

Retarget to 2.3, this is now manifesting when changing from reporting to kepler after Jing's change to include a workflow scheduler gui property (which does have an originModule property) in gui's configuration.

#2 Updated by Derik Barseghian almost 8 years ago

Ok, what's happening is reporting and workflow-run-manager override some properties in gui and common's configuration. When you override a property it doesn't get the originModule subproperty. If these configs get written to disk, and you switch back to e.g. vanilla, you'll get errors on startup. I believe this is a shortcoming with our current system. I'm not sure the solution...should overridden properties be written out along side the originals with an originModule subproperty, and we change the ConfigManager to choose the appropriate property based on what modules are active? This doesn't seems especially appealing or easy.

Most of the properties reporting and wrm override could actually instead be simply added with addProperty, thus getting originModule subproperties and avoiding the problem -- but unfortunately we have at least one that I think needs to be a true override, wrm's <viewPaneTabPanes><viewPane>Workflow.

We could possibly punt by putting the two new workflow-scheduler-gui properties in workflow-scheduler-gui's configuration (these are the only 2 properties in a soon to be published module that cause the problem that I know of -- but Dan may need to chime in wrt fault-tolerance), but I'd have to discuss that with Jing. We decided where he currently has them seems like the best place.

#3 Updated by Jing Tao almost 8 years ago

For workflow-scheduler-gui module, i changed to use overwrite approach adding the preference tabs. This approach wouldn't serialize the configure.xml on the gui module.

#4 Updated by Derik Barseghian almost 8 years ago

Discussed w/ Jing and Dan.
Can now be retargeted to 2.4.0.

#5 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5290

#6 Updated by Daniel Crawl about 4 years ago

  • Target version changed from 2.5.0 to 2.X.Y

Also available in: Atom PDF