Bug #5317
closedData Manager Library: Checks for collapseDelimiter instead of collapseDelimiters
0%
Description
There are two lines in the Data Manager Library source code that contain an apparent bug. The code checks for an EML element named "collapseDelimiter" when it should be checking for "collapseDelimiters". These lines are at:
src/org/ecoinformatics/datamanager/parser/eml/Eml200Parser.java, line 1204:
elementName.equals("collapseDelimiter") &&src/org/ecoinformatics/datamanager/parser/generic/GenericDataPackageParser.java, line 1278:
elementName.equals("collapseDelimiter") &&In addition, there are a large number of method names, method parameters, instance variables, and local variables throughout the DML code that are named 'collapseDelimiter' when the more appropriate name for these constructs would be 'collapseDelimiters'. Since these are only names, they do not affect the code logic, but it would be good to clean these up and rename them in accordance with the actual EML element name, 'collapseDelimiters'.
Updated by Duane Costa over 13 years ago
Fixed with the following update:
Author: costa
Date: 2011-02-22 09:26:30 -0800 (Tue, 22 Feb 2011)
New Revision: 2162
Modified:
trunk/src/org/ecoinformatics/datamanager/database/DatabaseLoader.java
trunk/src/org/ecoinformatics/datamanager/database/DelimitedReader.java
trunk/src/org/ecoinformatics/datamanager/parser/Entity.java
trunk/src/org/ecoinformatics/datamanager/parser/TextDelimitedDataFormat.java
trunk/src/org/ecoinformatics/datamanager/parser/eml/Eml200Parser.java
trunk/src/org/ecoinformatics/datamanager/parser/generic/GenericDataPackageParser.java
trunk/test/org/ecoinformatics/datamanager/parser/TextDelimitedDataFormatTest.java
trunk/test/org/ecoinformatics/datamanager/parser/eml/Eml200ParserTest.java
trunk/test/org/ecoinformatics/datamanager/parser/generic/Eml200DataPackageParserTest.java
trunk/test/org/ecoinformatics/datamanager/parser/generic/GenericDataPackageParserTest.java
Log:
Fix for Bug #5317: 'Data Manager Library: Checks for collapseDelimiter instead of collapseDelimiters'. The two lines of code that contained bugs (as described in the Bugzilla write-up) have been fixed. In addition, all references to 'collapseDelimiter' have been modified to 'collapseDelimiters', including variable names, methods names and parameters, JUnit test names, and comments.