Bug #5428
closedLeading whitespace in data URL causes download to hang
0%
Description
Leading whitespace in a data URL has been demonstrated to cause the Data Manager to hang during its download operation. A data package that demonstrates this behavior is:
http://metacat.lternet.edu/knb/metacat/knb-lter-sbc.10.15One of the two data table entities in the above data package contains leading white space:
"\n http://sbc.lternet.edu/external/Ocean/Data/Monthly_Water_Sampling/LTER_monthly_bottledata.txt"
The fix for this bug would be for the Data Manager to trim leading and trailing whitespace from the data URL.
A secondary enhancement would be for the Data Manager to produce a warning in the form of a quality check whenever it finds that the trimmed URL is different from the original URL. However, this secondary enhancement should be implemented in the DATAMANAGER_QUALITY branch rather than in the 'eml' trunk.
Updated by Duane Costa over 13 years ago
Fixed with the following update (see check-in comment for additional details):
Author: costa
Date: 2011-06-24 11:57:39 -0700 (Fri, 24 Jun 2011)
New Revision: 2196
Modified:
trunk/src/org/ecoinformatics/datamanager/download/DownloadHandler.java
Log:
Fix for Bug 5428 - 'Leading whitespace in data URL causes download to hang'. This fixes the immediately problem in the download handler, however, we may want to catch whitespace issues like this one earlier in the parsing process and for elements other than just the online URL. Also, the quality check enhancement as described in the Bug #5428 is not included as part of this update.
Modified: trunk/src/org/ecoinformatics/datamanager/download/DownloadHandler.java
Updated by Duane Costa over 13 years ago
Fixed with the following update:
Author: costa
Date: 2011-06-24 11:57:39 -0700 (Fri, 24 Jun 2011)
New Revision: 2196
Modified:
trunk/src/org/ecoinformatics/datamanager/download/DownloadHandler.java
Log:
Fix for Bug 5428 - 'Leading whitespace in data URL causes download to hang'. This fixes the immediately problem in the download handler, however, we may want to catch whitespace issues like this one earlier in the parsing process and for elements other than just the online URL. Also, the quality check enhancement as described in the Bug #5428 is not included as part of this update.
(As noted in the commit comment, this update does not include the data quality enhancement mentioned in the bug write-up. However, that enhancement is tangential to the bug fix itself, so I will close out this bug as being resolved.)