/ - Diff - Metacat - Ecoinformatics Redmine

« Previous | Next »

Revision 1130

Added by Jing Tao over 22 years ago

Change for every method to use getDBConnection and returnDBConnection to manage DBConnection.

+      {
         String uniqueid;
         String sysdate = dbAdapter.getDateTimeFunction();
         DBConnection conn = null;
         int serialNumber = -1;
         try {
           PreparedStatement pstmt;
           PreparedStatement pstmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.getUniqueID");
           serialNumber=conn.getCheckOutSerialNumber();
           pstmt = conn.prepareStatement
                   ("INSERT INTO accession_number (site_code, date_created) " +
                    "VALUES (?, " + sysdate + ")");
-...
           pstmt.execute();
           pstmt.close();
           uniqueid = "" + dbAdapter.getUniqueID(conn, "accession_number");
           uniqueid = "" + dbAdapter.getUniqueID("accession_number");
         } catch (SQLException e) {
           throw new
           SQLException("Error on AccessionNumber.getUniqueID(): "+e.getMessage());
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn, serialNumber);
+        }
         return uniqueid;
+      }
-...
                       throws SQLException {
         boolean hasAccNumber = false;
         DBConnection conn = null;
         int serialNumber = -1;
         try {
           PreparedStatement pstmt;
           PreparedStatement pstmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.accNumberUsed");
           serialNumber=conn.getCheckOutSerialNumber();
           pstmt = conn.prepareStatement(
                     "SELECT 'x' FROM xml_documents " +
                     "WHERE docid = ? " +
-...
         } catch (SQLException e) {
           throw new SQLException
           ("Error on AccessionNumber.accNumberUsed(accNumber): " + e.getMessage());
+        }
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn, serialNumber);
+        }
         return hasAccNumber;
+      }
-...
       private boolean accNumberIsCurrent(String accNumber) throws SQLException {
         boolean hasCurrentAccNumber = false;
         DBConnection conn = null;
         int serialNumber = -1;
         try {
           PreparedStatement pstmt;
           PreparedStatement pstmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.accNumberIsCurre");
           serialNumber=conn.getCheckOutSerialNumber();
           pstmt = conn.prepareStatement(
                     "SELECT 'x' FROM xml_documents " +
                     "WHERE docid = ?");
-...
           throw new SQLException(
               "Error on AccessionNumber.accNumberIsCurrent(String accNumber): " +
               e.getMessage());
+        }
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn, serialNumber);
+        }
         return hasCurrentAccNumber;
+      }
-...
       private String getLastRevision(String docid) throws SQLException
+      {
         String rev = "";
         DBConnection conn = null;
         int serialNumber = -1;
         try {
           PreparedStatement pstmt;
           PreparedStatement pstmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.getLastRevision");
           serialNumber=conn.getCheckOutSerialNumber();
           pstmt = conn.prepareStatement
                   ("SELECT rev FROM xml_documents WHERE docid='" + docid + "'");
           pstmt.execute();
-...
           throw new SQLException(
           "Error on AccessionNumber.getLastRevision(): " + e.getMessage());
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn,serialNumber);
+        }
         return rev;
+      }
-...
       private int getLastRevisionNumber(String docId) throws SQLException
+      {
         int rev = 1;
         DBConnection conn =null;
         int serialNumber = -1;
         try {
           PreparedStatement pStmt;
           PreparedStatement pStmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.getLastRevisionN");
           serialNumber=conn.getCheckOutSerialNumber();
           pStmt = conn.prepareStatement
                   ("SELECT rev FROM xml_documents WHERE docid='" + docId + "'");
           pStmt.execute();
-...
           throw new SQLException(
           "Error on AccessionNumber.getLastRevision(): " + e.getMessage());
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn,serialNumber);
+        }
         return rev;
+      }
-...
       private String getNextRevision(String docid) throws SQLException
+      {
         String rev = "";
         DBConnection conn = null;
         int serialNumber = -1;
         try {
           PreparedStatement pstmt;
           PreparedStatement pstmt = null;
           //check out DBConnection
           conn=DBConnectionPool.getDBConnection("AccessionNumber.getNextRevision");
           serialNumber=conn.getCheckOutSerialNumber();
           pstmt = conn.prepareStatement
                   ("SELECT rev+1 FROM xml_documents WHERE docid='" + docid + "'");
           pstmt.execute();
-...
           throw new SQLException(
           "Error on AccessionNumber.getNextRevision(): " + e.getMessage());
+        }
         finally
+        {
           DBConnectionPool.returnDBConnection(conn, serialNumber);
+        }
         return rev;
+      }

Also available in: Unified diff

Project

General

Profile

Metacat

Revision 1130

Added by Jing Tao over 22 years ago