Morpho

The condition seems backwards to me.� The reason it is in there is so thatthe same stylesheet can be used to create the HTML for
display in the UI and in the export.� In the UI, the top-level metadata is in a separate pane than the entity and attribute metadata,
and they each have their own mode.� In the export, the mode seems like it should be printall, and so the condition should be changed
to $displaymodule=='printall'.� But I'm not sure -- I think you'll need to carefully go through the logic of the conditionals to make
sure all of the cases are handled properly, then make the needed changes.

Matt

On Wed, Sep 30, 2009 at 9:44 AM, Jing Tao <tao@nceas.ucsb.edu> wrote:
Hi, Matt:

Your guess is right. But I think this is a bug in eml stylesheet.

In eml-attrubte.xsl code, there is a condition line:
      <xsl:when test="$displaymodule!='printall'">
      �......
      �<xsl:call-template name="attributecommonvertical">
      �.....
      </xsl:when>

This means when "displaymodule" does NOT equals "printall", the style sheet will display the attributes. I couldn't
      understand why we do this.

During the export action of morpho, the value of "displaymodule" is overwritten by "printall". So the html page doesn't
      have the attribute info.

I guess we should remove the condition line. Do you see any problem?

Thanks,

Jing

<table xsl:use-attribute-sets="cellspacing" class="{$tableattributeStyle}" width="100%">
<xsl:choose>
<xsl:when test="$displaymodule!='printall'">
<xsl:choose>
<xsl:when test="references!=''">
<xsl:variable name="ref_id" select="references"/>
<xsl:variable name="references" select="$ids[@id=$ref_id]" />
<xsl:for-each select="$references">
<!-- changed template name from attributecommon to attributecommonvertical -->
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:for-each>
</xsl:when>
<xsl:otherwise>
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:otherwise>
</xsl:choose>
</xsl:when>
<!-- Comment out redundent call
<xsl:otherwise>
<xsl:choose>
<xsl:when test="references!=''">
<xsl:variable name="ref_id" select="references"/>
<xsl:variable name="references" select="$ids[@id=$ref_id]" />
<xsl:for-each select="$references">
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:for-each>
</xsl:when>
<xsl:otherwise>
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
-->
</xsl:choose>
</table>

Above is our current code in attribute.xsl.

Someone (maybe myself) comment out the redundant code in the otherwise part. However, it left the condition - displaymodule!=printall. So when displaymodule=printall, it will do nothing.

Since in original code, the displaymodule equals or not equal printall will do same action, so we can remove the condition and redundant code.
So code will be:
<table xsl:use-attribute-sets="cellspacing" class="{$tableattributeStyle}" width="100%">
<xsl:choose>
<xsl:when test="references!=''">
<xsl:variable name="ref_id" select="references"/>
<xsl:variable name="references" select="$ids[@id=$ref_id]" />
<xsl:for-each select="$references">
<!-- changed template name from attributecommon to attributecommonvertical -->
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:for-each>
</xsl:when>
<xsl:otherwise>
<xsl:call-template name="attributecommonvertical">
<xsl:with-param name="docid" select="$docid"/>
<xsl:with-param name="entitytype" select="$entitytype"/>
<xsl:with-param name="entityindex" select="$entityindex"/>
</xsl:call-template>
</xsl:otherwise>
</xsl:choose>
</table>

After the changing, the import and morpho display work good.

This bug was fixed base on above solution.

Original Bugzilla ID was 4426