Bug #4791
closed
Actor names no longer have spaces
Added by Derik Barseghian over 14 years ago.
Updated over 14 years ago.
Description
At some point the spaces in component names went away. In 1.0 it was e.g. String Constant, but now it's StringConstant. Was there a reason for this? I think we should include the spaces (more user friendly, same as 1.0) unless there was a reason for this change.
I'm guessing this is related to the changes to the library/database. Aaron do you know?
I looked at this and it looks like the name of the actor is now derived from the name of the kar file. The name of the actor should be derived from the <entity name="xxx"> attribute in the actor metadata. I don't see an easy way to get this information from the KARCacheContent, however. The name gets set around line 654 of LibIndex.java. It uses the KARCacheContent.getShortName() method to set it. There needs to be a way to get the name of the actual actor, not the kar file.
Aaron, do you know a good way to fix this?
Hey guys, yeah looks like the LibIndex was using the name of the Jar entry found in the manifest and not the name that was extracted into the ActorMetadata object. To fix this it now gets the name from the CacheContent object that is populated in the creation of hte KARCacheContent object (since there is a foreign relation between the two in the database). Those two objects are holders for row information in the corresponding database tables.
Now the Name that shows up in the CacheContentTable is being used as the name for the library items and the spaces are preserved.
Because the kars are stored in the persistent KeplerData directory, a clean-cache will not show the difference after updating to revision 23068. You actually have to rebuild the library by going to "sources" and pressing the "build" button.
Oh and also closing this bug
Sorry a clean-cache should fix this, I think my partially updated version had trouble due to the new cache location...
Original Bugzilla ID was 4791
Also available in: Atom
PDF