Project

General

Profile

Bug #5099

Import Dependent Modules for KAR doesn't work

Added by Derik Barseghian almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Category:
general
Target version:
Start date:
07/21/2010
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5099

Description

If you create a KAR that depends on modules that you're not currently running, the KAR icon in the Components pane shows an exclamation mark and gives you the option to Import Dependent Modules. This action does not work however, because the modules it attempts to download don't exist -- the KAR MANIFEST.MF dependsOnModule and module-dependencies attributes are just storing module names without version numbers, so e.g. if you're configured to the test-releases area, and attempt to open a 'reporting KAR' in vanilla kepler, the import action will attempt to download:

https://code.kepler-project.org/code/kepler/releases/test-releases//provenance/provenance.zip

instead of:

https://code.kepler-project.org/code/kepler/releases/test-releases/provenance-2.0.0/provenance-2.0.0.zip

An additional problem is that if this fails to download, you get an error message, but it's followed by a message saying 'Module Download Complete' as if it had worked.

Aaron and David - I'm not sure what your decision was on this - should a KAR created w/ particular modules always be openable by those modules, no matter their version? It seems like the KAR MANIFEST should store the exact versions of the modules that were used to create it, for future identification. Having already released 2.0, if changes to the KAR MANIFEST are made, they should be backward compatible to support KARs users may have already made.


Related issues

Blocks Kepler - Bug #5119: Make switching to a specific set of modules turn off automatic update featureResolved08/04/2010

Blocks Kepler - Bug #5121: Provide a button to manually check for updatesResolved08/04/2010

Blocks Kepler - Bug #5147: Resolve issue with modules.txtResolved08/12/2010

Blocks Kepler - Bug #5143: not getting prompted to upgrade to available patched version in test areaResolved08/11/2010

Blocks Kepler - Bug #5157: Devise approach for when patching should occur when changes occur via the module-manager.Resolved08/20/2010

History

#1 Updated by Derik Barseghian almost 9 years ago

Checked in a first pass at this into 2.0 in r25165. Not yet in trunk.

#2 Updated by Derik Barseghian almost 9 years ago

These changes will be put into a new 2.1 branch, and removed from the 2.0 branch.

Yesterday I made more progress on the current plan, which Matt explains here:
http://mercury.nceas.ucsb.edu/kepler/pipermail/kepler-dev/2010-August/018716.html

#3 Updated by Derik Barseghian almost 9 years ago

This is implemented now, it just needs further testing once bugs #5147 and #5143 are fixed.

As part of this I've removed the File=>Save and File=>Save As menu items. Since module-dependencies are stored in kar manifests, attempting to open a workflow as xml in a suite that doesn't support that workflow's needs would result in errors, and not the import module dependency prompt you now get for kars. Discussion for this menu change, and how to re-enable them is found here:
http://mercury.nceas.ucsb.edu/kepler/pipermail/kepler-users/2010-August/002321.html

#4 Updated by Derik Barseghian almost 9 years ago

Done.

#5 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5099

Also available in: Atom PDF