Project

General

Profile

Bug #5649

opendap/{DapObjectsToToken,TokenManager,TypeManager} are almost identical

Added by Christopher Brooks over 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
actors
Target version:
Start date:
08/06/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5649

Description

opendap/src/org/kepler/dataproxy/datasource/opendap/DapObjectsToToken.java line 65
opendap/src/org/kepler/dataproxy/datasource/opendap/TokenMapper.java line 65 # lines : 257

These two files are ~750 lines each, yet have only 5 different lines
diff opendap/src/org/kepler/dataproxy/datasource/opendap/TokenMapper.java opendap/src/org/kepler/dataproxy/datas\
ource/opendap/DapObjectsToToken.java

65c65
< public class TokenMapper {
---

public class DapObjectsToToken {

321c321
< names[i] = TypeMapper.replacePeriods(dapBT.getName());
---

names[i] = DapObjectsToType.replacePeriods(dapBT.getName());

368c368
< names[i] = TypeMapper.replacePeriods(bt.getName());
---

names[i] = DapObjectsToType.replacePeriods(bt.getName());

412c412
< names0 = TypeMapper.replacePeriods(array.getName());
---

names0 = DapObjectsToType.replacePeriods(array.getName());

417c417
< names[i] = TypeMapper.replacePeriods(array.getName());
---

names[i] = DapObjectsToType.replacePeriods(array.getName());

History

#1 Updated by Christopher Brooks over 7 years ago

Also:

pendap/src/org/kepler/dataproxy/datasource/opendap/DapObjectsToType.java line 73
o
pendap/src/org/kepler/dataproxy/datasource/opendap/TypeMapper.java line 73
  1. lines : 285

bash-4.1$ diff rwb opendap/src/org/kepler/dataproxy/datasource/opendap/DapObjectsToType.java opendap/src/org/kepler/dataproxy/datasource/opendap/TypeMapper.java
61c61
< * @version $Id: DapObjectsToType.java 24000 2010-04-28 00:12:36Z berkley $
--

  • @version $Id: TypeMapper.java 24000 2010-04-28 00:12:36Z berkley $

64c64
< public class DapObjectsToType {
---

public class TypeMapper {

72,73c72,73
< public static String metadataName = DapObjectsToToken.metadataName;
< public static String valueName = DapObjectsToToken.valueName;
---

public static String metadataName = TokenMapper.metadataName;
public static String valueName = TokenMapper.valueName;

#2 Updated by Daniel Crawl about 7 years ago

I removed DapObjectsToToken.java and DapObjectsToType.java since they were no longer referenced.

#3 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5649

Also available in: Atom PDF