Project

General

Profile

Bug #5650

actors LidarWorkflowExecute and load WorkflowExecute have duplicated code

Added by Christopher Brooks almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
actors
Target version:
Start date:
08/06/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5650

Description

Duplicates detected with CPD. See

http://bugzilla.ecoinformatics.org/show_bug.cgi?id=4926#c1

actors/src/org/geon/LidarWorkflowExecute.java line 260
loader/src/org/geon/WorkflowExecute.java line 118 # lines : 387 duplicated

History

#1 Updated by Christopher Brooks almost 7 years ago

Also:
actors/src/org/geon/LidarWorkflowExecute.java line 373
actors/src/org/geon/ModelService.java line 267
loader/src/org/geon/WorkflowExecute.java line 227 # lines : 176

#2 Updated by Daniel Crawl almost 7 years ago

I marked all three as deprecated.

#3 Updated by Christopher Brooks almost 7 years ago

Why are all three deprecated?
Shouldn't two be marked deprecated with tags that suggest using the third?

For example:
@deprecated This actor is unsupported and contains duplicate code from @see {org.geon.WorkflowExecute} in the loader module. Please use that actor instead.

#4 Updated by Christopher Brooks almost 7 years ago

Check the deprecated tags, they should say why the actor was deprecated and
there should be FIXMEs that say where the duplicated code is located.

Or, as you say, we could move this code into a separate package that would never
be compiled.

#5 Updated by Daniel Crawl almost 7 years ago

I took another look at these three classes and found that WorkflowExecute and ModelService are almost a subset of LidarWorkflowExecute. I removed the deprecated tag from LidarWorkflowExecute and updated the tags for WorkflowExecute and ModelService.

#6 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5650

Also available in: Atom PDF