Project

General

Profile

Bug #5661

Remove SwingWorker and use javax.swing.SwingWorker

Added by Christopher Brooks almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
core
Target version:
Start date:
08/06/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5661

Description

./util/src/util/SwingWorker.java
FIXME: Remove and use javax.swing.SwingWorker.

See http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html

"The javax.swing.SwingWorker class was added to the Java platform in
Java SE 6. Prior to this, another class, also called SwingWorker, was
widely used for some of the same purposes. The old SwingWorker was not
part of the Java platform specification, and was not provided as part
of the JDK.

The new javax.swing.SwingWorker is a completely new class. Its
functionality is not a strict superset of the old SwingWorker. Methods
in the two classes that have the same function do not have the same
names. Also, instances of the old SwingWorker class were reusable,
while a new instance of javax.swing.SwingWorker is needed for each new
background task."

Also, remove ptolemy/src/ptolemy/gui/SwingWorker.java

History

#1 Updated by Christopher Brooks almost 7 years ago

I've removed ptolemy/src/ptolemy/gui/SwingWorker.java

Unfortunately, org.kepler.gui.ProgressMonitorSwingWorker uses util.SwingWorker.
Sadly, util.SwingWorker was not mentioned in the imports, the extends directive uses the full path:

public class ProgressMonitorSwingWorker extends util.SwingWorker

It looks like ProgressMonitorSwingWorker is used in one place:

./authentication-gui/src/org/kepler/authentication/GAMAAuthenticationService.java:import org.kepler.gui.ProgressMonitorSwingWorker;

To close this bug, GAMAAuthenticationService and ProgressMonitorSwingWorker need to be updated.

#2 Updated by Christopher Brooks almost 7 years ago

I removed util.SwingWorker and updated
authentication-gui/src/org/kepler/authentication/GAMAAuthenticationService.java
and
authentication-gui/src/org/kepler/gui/AuthenticateAction.java

I'm dispatching this to Jing because he edited these files in 2011 so
he might now how to best test the changes.

#3 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5661

Also available in: Atom PDF