Project

General

Profile

Bug #5758

Morpho revision handling is fragile

Added by ben leinfelder almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
morpho - general
Target version:
Start date:
12/03/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5758

Description

A few times in the past I've had trouble with the local-revisions file being unparsable by the apache config library. When I look at the content it is valid XML and looks fine. Eventually (after a few restarts of Morpho) I could get it to read the file correctly.

However, I did this again today and hadn't fully shutdown my first Morpho instance and then with two instances running I quit one then the next one. On start up the file was empty. My file was:
/Users/leinfelder/.morpho2/profiles/leinfelder/local-revisions.properties

This error seems to crop up when I "terminate" morpho abruptly (like form eclipse when it can't hot swap my latest changes).
I think we need to be able to recover from unplanned System.exits no matter what.


Related issues

Blocked by Morpho - Bug #5736: Morpho DataONE refactor - trackerNew11/19/2012

History

#1 Updated by Jing Tao almost 8 years ago

I can't duplicate the bug. But I did take a look at the code and found some nested synchronized code. The code was removed and hopely the issue has been fixed. Ben, please write a comment when you see it happen again.

#2 Updated by Jing Tao almost 8 years ago

I dug around the code again and found there were some code to modify the revision property during the initial method (reading the revision property file). So both reading and writing happened simultaneously. I removed this part. Hope the issue has been fixed.

#3 Updated by Jing Tao almost 8 years ago

After the change, morpho has worked very well for me. I am closing the bug. If there is any problem happen again, we can reopen this bug.

#4 Updated by Redmine Admin over 7 years ago

Original Bugzilla ID was 5758

Also available in: Atom PDF