Project

General

Profile

Bug #7019

cloning problems in NamedObj and AtomicActor

Added by Daniel Crawl about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
-
Target version:
Start date:
05/03/2016
Due date:
% Done:

90%

Estimated time:
Bugzilla-Id:

Description

I'm attaching a patch to fix cloning issues in NamedObj.java:

// Since _debugListeners is null, _debugging should be
// false to avoid error message in _debug()

and AtomicActor.java:

// When super.clone() is called below, attributes that are
// contained in this actor are also cloned, which includes
// calling methods on these attributes such as setContainer().
// These methods may add themselves to the firing listeners
// or initializables lists in the newObject clone, so we do
// not want to clear these lists in newObject after super.clone().
// Instead, save this instance's lists here and restore them after
// call super.clone().

cloning-patch.txt (2.28 KB) cloning-patch.txt Daniel Crawl, 05/03/2016 11:54 AM

History

#1 Updated by Christopher Brooks about 3 years ago

The patch looks good, but I'm going on vacation tomorrow and don't want to break the tree. I return next Tuesday and can take a look then.

#2 Updated by Daniel Crawl about 3 years ago

Sounds good. Thanks, Christopher.

#3 Updated by Christopher Brooks about 3 years ago

  • % Done changed from 0 to 90
  • Assignee changed from Christopher Brooks to Daniel Crawl

I've patched the ptII tree. I successfully ran the tests in kernel and actor/test. I'm reassigning this to Dan so that he may close it.

#4 Updated by Daniel Crawl about 3 years ago

  • Status changed from New to Resolved

Thanks, Christopher.

Also available in: Atom PDF