Project

General

Profile

Activity

From 04/23/2017 to 05/22/2017

05/22/2017

04:56 PM Bug #7189: memory leak in Manager
I've made adjustments for how we create and delete the shutdown hook. Let's wait a bit to see what happens before cl... Christopher Brooks
02:51 PM Bug #7190 (Resolved): memory leak due to hierarchy listeners when cloning
Daniel Crawl
02:35 PM Bug #7190: memory leak due to hierarchy listeners when cloning
I don't seem to have permission to close bugs, but this bug can be closed now. The nightly build seems to be working... Christopher Brooks

05/18/2017

02:57 PM Bug #7191 (Resolved): memory leak in CompositeActor for actor firing listeners
Looks good, thanks. Daniel Crawl
02:19 PM Bug #7191: memory leak in CompositeActor for actor firing listeners
Thanks for the patch, I patched CompositeActor.java and updated /ptolemy/module-info/revision.txt.
Feel free to ...
Christopher Brooks
01:10 PM Bug #7191 (Resolved): memory leak in CompositeActor for actor firing listeners
List of actor firing listeners needs to be null before cloning. I'm attaching a patch. Daniel Crawl
01:12 PM Bug #7190: memory leak due to hierarchy listeners when cloning
Oops, that should be: memory leak is gone, not going. Daniel Crawl
01:07 PM Bug #7190: memory leak due to hierarchy listeners when cloning
Thanks for the fix, Christopher. I verified the memory leak is going, so feel free to close the bug once the nightly ... Daniel Crawl
10:16 AM Bug #7190: memory leak due to hierarchy listeners when cloning
I'm not sure if this is right, but it solves the problem and passes tests.
I modified NamedObj.clone(Workspace) so...
Christopher Brooks
06:02 PM Bug #7190: memory leak due to hierarchy listeners when cloning
Ok, now I see Dan's text:
> In the usecase I'm debugging, the toplevel Composites in both the original and new mod...
Christopher Brooks
05:39 PM Bug #7190: memory leak due to hierarchy listeners when cloning
Interestingly, if I edit leak.java and replace Ramp with Const, then I don't have the leak. See the attached file, l... Christopher Brooks
10:28 AM Bug #7189: memory leak in Manager
I can take a look at this next week, after the dust settles from the other clone() bug. Christopher Brooks

05/17/2017

04:03 PM Bug #7190: memory leak due to hierarchy listeners when cloning
It seems like when we clone, it is not sufficient to set _hierarchyListeners to null in NamedObj, we also need to loo... Christopher Brooks

05/13/2017

05:42 PM Bug #7190: memory leak due to hierarchy listeners when cloning
I'm attaching a program that illustrates the leak. It creates a simple model containing Ramp, clones the model 100 ti... Daniel Crawl

05/12/2017

01:26 PM Bug #7189: memory leak in Manager
Good point. I'll keep this bug in my queue. Christopher Brooks
01:22 PM Bug #7189: memory leak in Manager
Ignoring the memory leak issue, the shutdown hook does not appear to be correctly implemented since it is unregistere... Daniel Crawl
12:53 PM Bug #7189: memory leak in Manager
BTW - the purpose of the shutdown hook is:
> Added a shutdown hook so that model is gracefully stopped when the JV...
Christopher Brooks
01:24 PM Bug #7190: memory leak due to hierarchy listeners when cloning
A simple model and a description of what to do would be sufficient. Christopher Brooks
01:23 PM Bug #7190: memory leak due to hierarchy listeners when cloning
I'm happy to provide a test case - what's the best format? Daniel Crawl
12:56 PM Bug #7190: memory leak due to hierarchy listeners when cloning
This is an interesting issue. To pursue it would require a test case.
We've seen plenty of issues with cloning of...
Christopher Brooks
05:09 PM Bug #7190 (Resolved): memory leak due to hierarchy listeners when cloning
When a model is cloned, some NamedObjs in the new model have hierarchy listeners from the original model, which preve... Daniel Crawl

05/11/2017

04:38 PM Bug #7189 (New): memory leak in Manager
The Manager registers a shutdown thread with the JVM, but does not unregister it after execute() is finished, which p... Daniel Crawl
 

Also available in: Atom