Metacat

In registerSystemMetadata(), lock the pid prior to calling map.containsKey(pid) since a put to the map could occur between the check and the subsequent put().

update authoritative member node id when we change it (reconfiguration) and when we initially register as a MN with the CN.

Correctly deserialize the BaseException subclass in handling calls to setReplicationStatus()

Use Lock instead of ILock to be consistent across classes.

After reviewing CNodeService and D1NodeService prompted by Robert comparing the Hazelcast locking with the d1_synchronization locking, I've made a number of changes that will prevent locking problems:

1) Multiple methods contained try/catch blocks that would:...

only delete replicated data files (server_location != 1)

use inherited access control from EML for the data file we download from a remote source
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5522

download remote data and save locally when it is referenced by an EML package, then include it in the ORE map.
http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5522

When the requested count in a call to listObjects() is 0, return an empty object list, not a full one. Fixes https://redmine.dataone.org/issues/2122

Minor formatting for querySystemMetadata().