Metacat

check for empty null (missing) node.subjectList. This should probably be a required element in the D1 schema, but it appears not. (ORNL entry was missing subjects in cn-dev environment)

no not record EML access rules that use the "denyFirst" permOrder.
https://redmine.dataone.org/issues/2614

needed to initialize the nodeList that stores matching nodes (by subject) -- this was the source of a NPE when we had a matching node subject.

do not create docid-guid mapping unless we are supposed to write access rules for the data to the dbase
https://redmine.dataone.org/issues/2572

As Ben suggested, don't compare to the node list if there are no replicas listed. This reduces the number of calls to listNodes() on the CN.

Minor logging change in throwing ServiceFailure when Hazelcast throws a RuntimeException.

Modify getSystemMetadata() to allow nodes that are listed as replicas to access the system metadata. Use the Session.Subject to find a list of nodes from the CN that match the subject, and compare those node ids to the listed replica node ids. Add listNodesBySubject() helper method to do so.

save backup properties before attempting node registration/update so that we don't "forget" the user input

add a parameter for optionally writing EML-embedded access control rules to the Metacat DB.
https://redmine.dataone.org/issues/2584
https://redmine.dataone.org/issues/2583

added comments and logging about https://redmine.dataone.org/issues/2572