Metacat

use a shared ExecutorService for replicate() calls.
https://redmine.dataone.org/issues/2623

remove extraneous pid and permission parameters from isAdminAuthorized() method and make public so that it can be called in other locations - namely before our asynchronous replicate() implementation on the MN.

check for empty null (missing) node.subjectList. This should probably be a required element in the D1 schema, but it appears not. (ORNL entry was missing subjects in cn-dev environment)

just use the e.getMessage() as e.getCause() may be null (seeing NPE when testing via the MN IT tester)

check for empty null (missing) node.subjectList. This should probably be a required element in the D1 schema, but it appears not. (ORNL entry was missing subjects in cn-dev environment)

no not record EML access rules that use the "denyFirst" permOrder.
https://redmine.dataone.org/issues/2614

needed to initialize the nodeList that stores matching nodes (by subject) -- this was the source of a NPE when we had a matching node subject.

do not create docid-guid mapping unless we are supposed to write access rules for the data to the dbase
https://redmine.dataone.org/issues/2572

As Ben suggested, don't compare to the node list if there are no replicas listed. This reduces the number of calls to listNodes() on the CN.

Minor logging change in throwing ServiceFailure when Hazelcast throws a RuntimeException.