Bug #1716

Feature requests for access screen in DPW

Added by Saurabh Garg over 14 years ago. Updated over 8 years ago.

morpho - general
Target version:
Start date:
Due date:
% Done:


Estimated time:


Features requested by people at the KNB workshop for access screen in DPW:

1. Provide data and time of the last access list update - below the table which
displays the access list.

2. Put a search box on top of the access table - so that someone could search
for a user without going through the whole list.


#1 Updated by ben leinfelder over 8 years ago

1. could probably write this information into the config.xml file when we successfully refresh the access list

2. simple filter on name, username and email address? (field LIKE "%search_string%")

#2 Updated by ben leinfelder over 8 years ago

actually just using the lastModified timestamp on the access file would be better

#3 Updated by ben leinfelder over 8 years ago

Search box added. Here's the current approach:
-looks at the value in the name field as given by the tree node's toString() method (includes username)
-matches include wildcards on either end of the search string
-the tree is regenerated with only matched usernames contained.
-there is no pruning of empty branches.

#4 Updated by ben leinfelder over 8 years ago

added pruning of empty branches and also expanding the search results when complete

#5 Updated by ben leinfelder over 8 years ago

now invoking the search when you hit <enter> in the search field.

#6 Updated by ben leinfelder over 8 years ago

closing this wit hone note: empty groups and/or organizations will not be shown in the tree now.

#7 Updated by ben leinfelder over 8 years ago

from Jim Regetz:
Two things (or three, depending on how you count):

1a. The search isn't cleared after you close the dialog. I can imagine this causing confusion the next time someone opens the dialog. But perhaps more critically, it causes this problem:

  • open a DP that already includes an access row for Jim Regetz.
  • click Add, search for "leinfelder", then hit Cancel
  • now select the Regetz entry, and click edit

The edit panel doesn't display the tree, but instead just has a text field with the LDAP DN for Regetz. Kinda cool that Morpho is evidently able to do this in cases where the user isn't in the tree, but I don't think this is what we want to happen in this case.

(Incidentally, it looks like even if you are editing an access rule after resetting the tree, and you do a search that doesn't return the user you are currently editing, you end up getting this text box. But I'm willing to live with that.)

1b. Since I assume you will need to introduce some access tree "reset" operation that will trigger upon dialog close, can you also add a reset button next to the search button? Searching for an empty string effectively does the same thing, but it takes a second or two, and it returns a fully expanded tree (thanks to my previous suggestion :).

2. Hitting <enter> does indeed trigger the search now, and won't close the dialog box even if I've selected a user. Nice! But I still get a red "Warning: Invalid input! Please make a selection." at the bottom of the dialog.

I would call 1a critical, 1b nice to have (but probably easy after 1a?), and 2 just an FYI in case there's an obvious fix.

#8 Updated by ben leinfelder over 8 years ago

Jim's previous comments were fixed, except:
-you will get a text field if you search for a user when editing an existing entry and that original entry does not exist in your filtered tree. at which point you will need to cancel the dialog and start again unless you want to manually enter the new value.

#9 Updated by Redmine Admin about 6 years ago

Original Bugzilla ID was 1716

Also available in: Atom PDF