from Jim Regetz:
---
Two things (or three, depending on how you count):
1a. The search isn't cleared after you close the dialog. I can imagine this causing confusion the next time someone opens the dialog. But perhaps more critically, it causes this problem:
- open a DP that already includes an access row for Jim Regetz.
- click Add, search for "leinfelder", then hit Cancel
- now select the Regetz entry, and click edit
The edit panel doesn't display the tree, but instead just has a text field with the LDAP DN for Regetz. Kinda cool that Morpho is evidently able to do this in cases where the user isn't in the tree, but I don't think this is what we want to happen in this case.
(Incidentally, it looks like even if you are editing an access rule after resetting the tree, and you do a search that doesn't return the user you are currently editing, you end up getting this text box. But I'm willing to live with that.)
1b. Since I assume you will need to introduce some access tree "reset" operation that will trigger upon dialog close, can you also add a reset button next to the search button? Searching for an empty string effectively does the same thing, but it takes a second or two, and it returns a fully expanded tree (thanks to my previous suggestion :).
2. Hitting <enter> does indeed trigger the search now, and won't close the dialog box even if I've selected a user. Nice! But I still get a red "Warning: Invalid input! Please make a selection." at the bottom of the dialog.
I would call 1a critical, 1b nice to have (but probably easy after 1a?), and 2 just an FYI in case there's an obvious fix.