Project

General

Profile

Bug #3824

Normalize the app deploy dir in build.properties

Added by Michael Daigle almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Category:
metacat
Target version:
Start date:
02/17/2009
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
3824

Description

Per Duane Costa:

in build.properties file:

app.deploy.dir=/usr/local/devtools/jakarta-tomcat/webapps

It would be nice if this could be changed to:
app.deploy.dir=${build.tomcat.dir}/webapps
This would mean that many installations would be able to use
the default value, hence, one less property that needs to be edited
for many Metacat administrators.

Related issues

Blocks Metacat - Bug #3777: Move Tomcat libraries into metacat buildResolved01/26/2009

History

#1 Updated by Michael Daigle almost 11 years ago

My response:

The problem with 3 A is that the build.tomcat.dir is not necessarily the same as the app.deploy.dir. On knb (and other systems), we deploy to a completely different directory.

I think the build.tomcat.dir is only used to get some tomcat libraries. I have it on my list to include those libraries in metacat and remove the build.tomcat.dir property completely.

#2 Updated by Michael Daigle almost 11 years ago

Referencing ticket 3777 which moves tomcat libs into metacat project and eliminates build.tomcat.dir from build.properties.

#3 Updated by Matt Jones almost 11 years ago

We used to include those libs back in the Tomcat 3 days, but took them out as
the servlet library jars changed in Tomcat 3, 4, 5, and 6. So now we use the
locally installed version of the jar that comes with Tomcat to build. We
should consider whether adding these jars to Metacat is really an advantage --
we have to have Tomcat, and we have to differentiate which version of Tomcat is
being used in order to find the right jar file for servlet support. Having
those be in Metacat may not gain us much, and we'd have to differentiate which
to use in any given build. I'd opt for improving the build logic to discover
the jar files in the locally installed Tomcat. And I agree with Duane -- it
would be nice if the default app.deploy.dir used the standard webapps location,
as that is where most people will want to put it. So, I vote for changing back
to:
app.deploy.dir=${build.tomcat.dir}/webapps
Then if we need a different location in our particular install we can change it
as needed when we build and install locally. But the default should be the
standard webapps location.

#4 Updated by Michael Daigle almost 11 years ago

Yeah, makes sense. Unfortunately, there is another domain specific issue (to be solved) which is that the knb website build can do an automated checkout and build of metacat. That means that metacat has to be configured to build exactly for the knb site. Thus the default hard coded

/usr/local/devtools/jakarta-tomcat/webapps

Directory.

I'll look into this further for the next release.

#5 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 3824

Also available in: Atom PDF