Project

General

Profile

Bug #4619

WorkflowRuns not showing inside KARs in library

Added by Derik Barseghian over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Category:
general
Target version:
Start date:
12/09/2009
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
4619

Description

WorkflowsRuns that are inside kars haven't been showing up in the component library for awhile now beneath an expanded KAR. ROMLs and RIOs show though.


Related issues

Blocks Kepler - Bug #4689: Export run creates duplicate WorkflowRun files. Exporting it again gives none.Resolved01/21/2010

Blocks Kepler - Bug #4800: CacheManager can not insert WorkflowRun into cacheResolved02/17/2010

History

#1 Updated by Derik Barseghian over 9 years ago

Leaving off here for now: problem is related to fact that insertEntryIntoCache fails when trying to insert WorkflowRun in kar_contents table because it's not found in cachecontenttable.

#2 Updated by Derik Barseghian over 9 years ago

partially fixed in r22162. You can now export the same run to different kars, and the run momls will show up in the tree. The changes in r22162 are a bit odd, I'll try to go over them to see if I can do it in a cleaner way. If anyone else makes any changes in this area, i.e. wrt how WorkflowRuns are dealt with in OM or in the 3 handlers that manipulate them, please test that subsequent exports of the same run to different kars works (the runs show up in the component library, and have the right values in serialized form).

There are still problems here that I'm going to try to sort out:
a) If you export a run, then tag the run and export it again to a differnt kar, kar2 in the library won't show the run.
b) 'View LSID' on the WorkflowRun in the library only shows the correct lsid for the most recent WorkflowRun in the most recent kar. Prior runs in prior kars show the original entityId lsid, not the proper revisions. The serialized forms still come out right however.

#3 Updated by Matt Jones over 9 years ago

Derik -- it sounds to me like you need to develop a set of unit tests that exercise this functionality, in this case saving the run to a kar and then test that subsequent exports of the same run to different kars works. By automating this test and running it regularly, you can move on with confidence to other issues. We seem to be spinning our wheels, fixing one thing and in the process breaking others. Appropriate unit tests will reduce that.

#4 Updated by ben leinfelder over 9 years ago

While unit tests would probably minimize this wheel spinning, I think it's non-trivial to develop them. Most of the intricacies come to light in the GUI; actions are invoked and results viewed there.

#5 Updated by Derik Barseghian over 9 years ago

r22184 has re-broken this. KARFile now warns:
WARN (org.kepler.kar.KARFile:cache:838) KAREntry was not recognized: WorkflowRun.1.xml

Reverting to r22183 (provenance/Initialize.java) fixes the bug. Chad, do you know what's wrong?

#6 Updated by Derik Barseghian over 9 years ago

r22211 fixes problem in comment#5.

#7 Updated by Derik Barseghian about 9 years ago

this is working again. closing.

#8 Updated by Redmine Admin about 6 years ago

Original Bugzilla ID was 4619

Also available in: Atom PDF