Project

General

Profile

Actions

Bug #5259

closed

kepler/util/src/util/LineReader.java should be updated to match Ptolemy sources

Added by Christopher Brooks almost 14 years ago. Updated about 12 years ago.

Status:
Resolved
Priority:
Normal
Category:
actors
Target version:
Start date:
12/17/2010
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5259

Description

Edward Lee identified and fixed the following bug in ptolemy.actor.lib.io.LineReader:
r59929 | eal | 2010-12-07 17:52:16 -0800 (Tue, 07 Dec 2010) | 8 lines

LineReader used to produce output on its endOfFile port
in its postfire() method. This is incorrect. No actor should
produce output in postfire(). I've corrected this so that the
output is produced in fire(). The output will be true in the
same firing where the last line is produced on the output
port. Thus, in SDF, you can connect the endOfFile port to
a Stop actor, and the model will stop executing after
processing the last line in the file.

Kepler has a copy of this code at util/src/util/LineReader.java that should
be examined for this bug.

Ideally, this duplicate file would be removed and any changes necessary folded
in to the Ptolemy tree.

Actions

Also available in: Atom PDF