Bug #5648
FileCopier code duplication
0%
Description
FileCopier:
./core/src/org/kepler/util/FileCopier.java - Fixed. Unused code which was removed.
./actors/src/org/sdm/spa/actors/transport/FileCopier.java - abstract base class extended by
./actors/src/org/sdm/spa/actors/transport/SftpCopier.java:public class SftpCopier extends FileCopier {
./actors/src/org/sdm/spa/actors/transport/ScpCopier.java:public class ScpCopier extends FileCopier {
./actors/src/org/sdm/spa/actors/transport/LocalFileCopier.java:public class LocalFileCopier extends FileCopier {
./actors/src/org/sdm/spa/actors/transport/SrmliteCopier.java:public class SrmliteCopier extends FileCopier {
./actors/src/org/sdm/spa/actors/transport/BbcpCopier.java:public class BbcpCopier extends FileCopier {
Fixed - Renamed this to FileCopierBase
The class that use FileCopier base is
actors/src/org/sdm/spa/actors/transport/FileCopierFactory.java
The Actor is:
actors/src/org/sdm/spa/actors/transport/GenericFileCopier.java
These two actors should be modified to call GenericFileCopier.java
./actors/src/org/resurgence/actor/FileCopier.java
./actors/src/org/kepler/actor/ssh/FileCopier.java
History
#1 Updated by Derik Barseghian over 8 years ago
./core/src/org/kepler/util/FileCopier.java was used by tagging. I've temporarily resurrected it, but into the tagging module, so we can compile. It most likely should be deleted and replaced though:
New Revision: 30355
Added:
trunk/modules/tagging/src/org/kepler/tagging/util/FileCopier.java
Log:
temporarily restore this FileCopier class deleted at r30351, which is used by tagging. It has hardcoded references to a WATERS perl package(?). Ask Sean to verify this isn't used by anything else, and can be deleted and replaced by some more standard file copy.
#2 Updated by Sean Riddle over 8 years ago
Closed by r30689. Duplicate code removed and call to such code was replaced to a call to the canonical file copier implementation.
#3 Updated by Redmine Admin almost 8 years ago
Original Bugzilla ID was 5648