Project

General

Profile

Bug #3094

File keyboard shortcuts use ctrl key instead of apple key on Mac

Added by Shawn Bowers almost 12 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Normal
Category:
interface
Target version:
Start date:
01/22/2008
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
3094

Description

Unlike in View and Edit, File shortcuts use ^Key (ctrl+Key) instead of Apple^Key. These shortcuts include:

  • Open File
  • Save
  • Print
  • Close

Note also that on the actor right-click menu, Open Actor is Apple^L, whereas Configure Actor is Ctrl^E. In the original design, these were both supposed to be Apple^Key I believe.

History

#2 Updated by Derik Barseghian almost 12 years ago

I'll work on this for bug day today.

#3 Updated by Derik Barseghian almost 12 years ago

The Accelerators for the File Menu for OS X, i.e. * Open File * Save * Print * Close
have been fixed.

Configure Actor still needs to be fixed.

#4 Updated by Christopher Brooks almost 12 years ago

I folded a change from Derek (via Chad) to ConfigurationAction.java
into the ptII tree.

If you are having problems with CTRL_MASK, then looking at some of
the other places where it is used might be of interest.

Someone should check these:
ptII/diva/canvas/event/LayerEvent.java:
case InputEvent.CTRL_MASK:
ptII/diva/canvas/event/LayerEvent.java:
return "CTRL_MASK";
ptII/diva/canvas/event/MouseFilter.java:
private int _modifierMask = InputEvent.SHIFT_MASK | InputEvent.CTRL_MASK
ptII/diva/graph/basic/BasicGraphController.java:
InputEvent.BUTTON1_MASK, InputEvent.CTRL_MASK);
ptII/diva/gui/GUIUtilities.java:
if ((modifiers & Event.CTRL_MASK) Event.CTRL_MASK) {
ptII/ptolemy/actor/gui/PortConfigurerDialog.java: .getModifiersEx() | java.awt.event.InputEvent.CTRL_MASK) java.awt.event.InputEvent.CTRL_MASK))))

These in ptolemy/apps can be ignored
ptII/ptolemy/apps/vergil/graph/MetaEdgeController.java:
InputEvent.CTRL_MASK);
ptII/ptolemy/apps/vergil/graph/MetaNodeController.java:
InputEvent.CTRL_MASK);

Ignore, chic is not used by Kepler:
ptII/ptolemy/chic/ChicController.java:
KeyEvent.VK_L, Event.CTRL_MASK));

Maybe this one can be ignored for Kepler:
ptII/ptolemy/gui/ShellTextArea.java:
case InputEvent.CTRL_MASK:

Maybe this one can be ignored for Kepler:
ptII/ptolemy/media/AudioViewer.java:
Event.CTRL_MASK));

Someone should check these out:
ptII/ptolemy/plot/PlotFrame.java:
Event.CTRL_MASK));
ptII/ptolemy/plot/PlotFrame.java:
Event.CTRL_MASK));
ptII/ptolemy/plot/PlotFrame.java:
Event.CTRL_MASK));
ptII/ptolemy/plot/PlotFrame.java:
Event.CTRL_MASK));
ptII/ptolemy/vergil/toolbox/MoveAction.java:
KeyEvent.VK_B, Event.CTRL_MASK));
ptII/ptolemy/vergil/toolbox/MoveAction.java:
KeyEvent.VK_F, Event.CTRL_MASK));

Ignore these two, they are in comments:
ptII/ptolemy/vergil/toolbox/ConfigureAction.java:
// Call getMenuShortcutKeyMask() instead of Event.CTRL_MASK
ptII/ptolemy/vergil/toolbox/EditIconAction.java:
// KeyStroke.getKeyStroke(KeyEvent.VK_I, Event.CTRL_MASK));

Ignore, Kepler does not use this code:
ptII/thales/vergil/navigable/NavigableActorGraphFrame.java:
.getKeyStroke(KeyEvent.VK_EQUALS, java.awt.Event.CTRL_MASK));

Ignore, these are used by the gui builder and not Kepler:
ptII/org/mlc/swing/layout/FormEditor.java:
KeyEvent.VK_D, KeyEvent.CTRL_MASK));
ptII/org/mlc/swing/layout/LayoutFrame.java:
KeyEvent.CTRL_MASK));
ptII/org/mlc/swing/layout/LayoutFrame.java:
KeyEvent.CTRL_MASK));

#5 Updated by Derik Barseghian almost 12 years ago

The change Christopher mentions fixed Configure Actor, as mentioned in comment #3.
I have not been able to find any other accelerators that need fixing in Kepler, so I am closing this bug.
Please report or reopen this bug should you find any.

#6 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 3094

Also available in: Atom PDF