Module manager should run patch checker before restart
If the user uses the module manager to do something that would require a restart of Kepler, for example, changing to a released suite, then relative entries in the modules.txt file are only resolved in relation to locally available modules. Upon next run, the patch checker may find remote modules that may need updating. If possible, the patch checker should be run before the restart to remove the need for the additional restart.
#1 Updated by Derik Barseghian over 7 years ago
The problem hinted at in the example above, downloading the wrong/old patch number 0 modules for an x.y.^ suite is fixed at r28635. I described the fix in part of my commit msg:
make ModuleDownloader() a constructor -- looked like a constructor, javadoc declares it a constructor, and is called in various places as a constructor, but it was not. With an uninitialized release variable downloadModules was failing to find and download available patches. This caused the problem where restarting into a x.y.^ suite would download old modules, and you'd then get prompted to get the patches on restart. Wasteful download, extra restart. Given as example in http://bugzilla.ecoinformatics.org/show_bug.cgi?id=5482