Project

General

Profile

Bug #5589

Add missing ptolemy actors to library

Added by Derik Barseghian over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
actors
Target version:
Start date:
04/23/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5589

Description

We should look through ptolemy's source and add Kepler library representations for any actors we don't already display and that will work in Kepler. Today the need for some of the Matrix actors came up, and they're two years old, so I suspect there are a number of ptolemy actors we should add.
kepler.sh -createActorXML can be used.
We could probably issue a patch to the actors module.

missing-actors.txt (32.1 KB) missing-actors.txt Daniel Crawl, 07/02/2012 03:27 PM
missingActors.txt (41.1 KB) missingActors.txt Christopher Brooks, 07/20/2012 10:50 AM

History

#2 Updated by Daniel Crawl over 7 years ago

I added a new ant target, "find-missing-actors", to list the files of actors, directors, and parameters not in the actor tree, and attached the output to this bug. Christopher, if you tell me what can be added to Kepler, I'll create the metadata files so they appear in the actor tree. Many of the Ptolemy files belong to domains not currently present in Kepler, e.g., SR, Rendezvous, Taskpt, etc. If these are not available in Kepler, then it would be good to update build-area/settings/ptolemy-excludes.

#3 Updated by Christopher Brooks over 7 years ago

The list did not include attributes in vergil/actor/lib?

There are some actors that are listed that are base classes for actors
that are already included.

#4 Updated by Daniel Crawl over 7 years ago

Thanks, Christopher! I added most of the actors and attributes on the list. I also updated ptolemy-excludes.

I couldn't create kar entries for some of the actors because clone() threw an NPE:

[null] java.lang.NullPointerException
[null] at ptolemy.actor.lib.ComputeHistogram.clone(ComputeHistogram.java:197)
[null] java.lang.NullPointerException
[null] at ptolemy.actor.lib.Lattice.clone(Lattice.java:182)
[null] java.lang.NullPointerException
[null] at ptolemy.actor.lib.RecursiveLattice.clone(RecursiveLattice.java:184)

#5 Updated by Christopher Brooks over 7 years ago

I added a test that, for each configuration, instantiates an actor and then
calls clone on the actor.

I fixed clone(Workspace) in ptolemy/actor/lib/ComputeHistogram.java
and ptolemy/actor/lib/RecursiveLattice.java

#6 Updated by Daniel Crawl over 7 years ago

Thanks again, Christopher. After your fix, I was able to add entries for ComputeHistogram, RecursiveLattice, VariableRecursiveLattice, Lattice, and VariableLattice.

#7 Updated by Redmine Admin over 6 years ago

Original Bugzilla ID was 5589

Also available in: Atom PDF