Project

General

Profile

Actions
Copy link

Bug #624

closed

eml-methods/methodsType needs clarification on choice/sequence

Added by David Blankman about 22 years ago. Updated about 22 years ago.

Status:
Resolved
Priority:
Immediate
Assignee:
David Blankman
Category:
eml - general bugs
Target version:
EML2.0.0rc3
Start date:
10/09/2002
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
624

Description

The current model for methodsType is a repetable choice of methodSteps (1 or
more) or sampling (0 or 1) or qualityControl (0 or more). This should be either:

1. a repeteable choice of methodStep or qualityControl or sampling

or

2. Sequence of methodSteps (1 or more), sampling (0 or 1?), qualityControl (0 or
more?).

We need to get some agreement on which model to use.

I recomend that we go with option 1.

Files

Download all files
ProcedureStepTypeFix.png (4.04 KB) ProcedureStepTypeFix.png David Blankman, 10/11/2002 10:36 AM
MethodsType_option1.png (7.64 KB) MethodsType_option1.png David Blankman, 10/11/2002 10:38 AM
MethodsType_option2.png (7.38 KB) MethodsType_option2.png David Blankman, 10/11/2002 10:39 AM
MethodsType_option3.png (7.1 KB) MethodsType_option3.png David Blankman, 10/11/2002 11:02 AM
Actions
Copy link
 #1

Updated by David Blankman about 22 years ago

Shows proposed changes.

Actions
Copy link
 #2

Updated by David Blankman about 22 years ago

Proposed fix of MethodsType without name change.

Actions
Copy link
 #3

Updated by David Blankman about 22 years ago

Proposed changed for MethodsType with name changes

Actions
Copy link
 #4

Updated by David Blankman about 22 years ago

1. ProcedureStepType needs to be fixed. See attached ProcedureStepTypeFix.png
for proposed changes.

2. MethodsType should be changed. While technicly correct the current model is:

methodStep+ | sampling? | qualityControl*. This should probably be changed to
either:

A. methodStep+ | sampling | qualityControl+ (see MethodsType_option1.png)
       or
   B. methodStep | sampling | qualityControl

I recommend B since the choice is repetable and since both methodStep and
qualityControl are of type ProcedureStepType which allows for subSteps.

I also recommend that methodStep be renamed to method and subStep be renamed to
step (see MethodsType_option3.png). Both methodStep and qualityControl are of
type ProcedureStepType. For consistency we should have either:

A. methodStep and qualityControlStep
       or
   B. method and qualityControl.

I recommend option B.

David Blankman

Actions
Copy link
 #5

Updated by David Blankman about 22 years ago

Proposed change for MethodsType with name changes.

Actions
Copy link
 #6

Updated by Peter McCartney about 22 years ago

Im on irc right now with david and have realized that I made an error in my
files that i never caught. The intended design was to be

methodsType(methodStep+,sampling?,qualityControl*)

Actions
Copy link
 #7

Updated by David Blankman about 22 years ago

Made changes to ProcedureStepType and MethodsType. MethodsType model changed
from choice to sequence as indicated in this previous comment:

Additional Comment #6 From Peter McCartney 2002-10-11 12:50 -------

I made an error in my files that i never caught. The intended design was to be
methodsType(methodStep+,sampling?,qualityControl*)

Actions
Copy link
 #8

Updated by Redmine Admin over 11 years ago

Original Bugzilla ID was 624

Actions
Copy link

Also available in: Atom PDF