Kepler

retarget/assign

We solved this by adding the 'lock report' feature.

i don't think that's a "fix" for this issue.
If I've been making report layout changes and then i close Kepler, I am not prompted to save the report (because the workflow has not changed).
How does "locking" the report solve this issue?

This dialog also comes up in at least two cases when it shouldn't:
1) don't have a report design underway
2) when changing to a report design that's the same as the current.

There is a prompt showing up now, but still need to add the save if they answer yes.

They are now prompted to save, and if they answer yes, their work is saved to a KAR.

This doesn't work for me. If I design a workflow and report layout, save it to kar, change the report layout, and then close the kepler window, I see a dialog popup and immediately disappear, and the window just closes. If I open an existing kar that has a report, then change the report, I don't think I see the dialog at all, the window just closes. Under some other circumstance I did see the dialog, but when I clicked yes, I got an NPE and the dialog kept popping back up.

Can you please tell me what revision number you have for this ? What you are describing sounds like an old version. In a few minutes, I will check it in again to both trunk and 2.0 branch. Please update.

This is at r24529 on reporting trunk. You haven't made changes post that revision that are checked in. Are you not seeing this behavior? What revision are you at?

Revision 24531 is the most recent, I have updated the files in both trunk and in the 2.0 branch. In this revision. Derik, in this version I do not see the problems you have described. Thanks.

Things still behave as described in comment7 at r24535 in reporting trunk for me, on both os X and windows XP.

I am still not seeing the behavior that you describe. This was however, a behavior that was present in a previous version, that had since been fixed. The previous cause of the behavior was that the code had used a timer to wait before closing the window - but this was completely removed in the newer version. It was replaced by an override of the windowClosing event. Can you please describe the steps that you are taking so that I can try to replicate it. Is this happening for you in the 2.0 branch as well ?
Thanks.

The steps I'm taking are as described in comment#7. Yes, this happens in 2.0 as well. If it's not happening for you, and you've created a fix, perhaps it's not checked in. Can you check that you're not out of sync w/ the repository?

Figured out what is happening here. Ptolemy > gui > Top _queryForSave method is being used instead of the ReportDesignerPanel DefaultCloseOperation.

Fixed at r25050 in 2.0 branch.
I'm going to wait until further work on reporting is done before i merge 2.0 branch changes into trunk.

I merged a long time ago. Just tried and works on trunk, closing.

Original Bugzilla ID was 4524