Project

General

Profile

Actions
Copy link

Bug #5665

closed

modulemanager et al.: swing-worker-1.2.jar should be removed

Added by Christopher Brooks over 12 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Daniel Crawl
Category:
interface
Target version:
2.5.0
Start date:
08/06/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5665

Description

bug #5661 is about removing util.SwingWorker.

Unfortunately, there is code that uses a different SwingWorker from module-manager/lib/jar/swing-worker-1.2.jar

./gui/src/org/kepler/gui/kar/ImportModuleDependenciesAction.java:import org.jdesktop.swingworker.SwingWorker;
./module-manager-gui/src/org/kepler/modulemanager/gui/AvailableModulesPanel.java:import org.jdesktop.swingworker.SwingWorker;
./module-manager-gui/src/org/kepler/modulemanager/gui/CurrentSuitePanel.java:import org.jdesktop.swingworker.SwingWorker;
./module-manager-gui/src/org/kepler/modulemanager/gui/ModulesList.java:import org.jdesktop.swingworker.SwingWorker;
./module-manager-gui/src/org/kepler/modulemanager/gui/patch/UpgradeDialogPanel.java:import org.jdesktop.swingworker.SwingWorker;
./module-manager-gui/src/org/kepler/modulemanager/gui/SuitesList.java:import org.jdesktop.swingworker.SwingWorker;

bash-3.2$ jar -tvf ./module-manager/lib/jar/swing-worker-1.2.jar
0 Fri Jul 25 15:51:54 PDT 2008 META-INF/
106 Fri Jul 25 15:51:52 PDT 2008 META-INF/MANIFEST.MF
0 Fri Jul 25 15:51:50 PDT 2008 org/
0 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/
0 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/
1202 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/AccumulativeRunnable.class
673 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingPropertyChangeSupport$1.class
940 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingPropertyChangeSupport.class
925 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$1.class
901 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$2.class
801 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$3.class
1034 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$4.class
472 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$5.class
1230 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$6.class
1473 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$7.class
1516 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$DoSubmitAccumulativeRunnable.class
1038 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$StateValue.class
830 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$SwingWorkerPropertyChangeSupport$1.class
1064 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker$SwingWorkerPropertyChangeSupport.class
5491 Fri Jul 25 15:51:50 PDT 2008 org/jdesktop/swingworker/SwingWorker.class

Wikipedia says that org.jdesktop.swingworker.SwingWorker is a backport of
SwingWorker to Java 1.5. Kepler requires Java 1.6, so this is no longer necessary.
See http://en.wikipedia.org/wiki/SwingWorker and
http://java.net/projects/swingworker/

The reason to move towards javax.swing.SwingWorker is because it is now
the standard SwingWorker. Having a class with the same name but a different
set of methods will cause confusion. In addition, javax.swing.SwingWorker is
maintained, org.jdesktop.swingworker.SwingWorker is probably not maintained at
all or is not as well maintained.

Actions
Copy link

Also available in: Atom PDF