Kepler

By using the ptolemy.actor.gui.TextEditor when "Open Actor" is invoked on the RExpression we can support having multiple editor (and display) windows open simultaneously so that copying and pasting among them easier.

This change can go into the Kepler code base (RExpression class) without any modifications to the underlying ptolemy sources.

Note: We'll hopefully get the go-ahead to add "undo" functionality to this TextEditor, too. But this would depend on approval from the ptII folks.

Until a change is included in ptII code (specifically ptolemy.actor.gui.TextEditorTableau), only one RExpresison text editor will be shown at a time (you can still look at other actors and execute the workflow with this single editor open, however).

The change mentioned makes sure the frame (or is it a Tableau?) title is set to the R actor's name so that multiple text editors are opened for each different script. Currently they all use the same frame titled "Unnamed"

The change to TextEditorTableau is marked below
if (frame == null) {
frame = new TextEditor(title, container.getDocument());
}

frame.text.setColumns(80);
        frame.text.setRows(40);
-->     setTitle(frame.getTitle());
        setFrame(frame);
        frame.setTableau(this);

The problem is that if I make this change, then under Ptolemy the titlebar
does not get updated with the filename. Here's how to reproduce this:
1. Make the above change to TextEditorTableau and recompile Ptolemy
2. File | New | Text Editor
3. Type some text
4. File | Save As
5. Save the file as data.txt
The title bar does not get updated with the title.

If I revert the change, and repeat, then the titlebar gets updated.
At least it did for my test

It's less than ideal to have a bunch of open text editor windows all named "Unnamed".
But I think we can handle it for the time being.

Ok, I put the setTitle inside the if block, so this might now work.
What we have is:

if (frame == null) {
            frame = new TextEditor(title, container.getDocument());
            // Set the title for the Kepler R actor
            // http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3187
            setTitle(frame.getTitle());
        }

frame.text.setColumns(80);
        frame.text.setRows(40);
        setFrame(frame);
        frame.setTableau(this);

This might have solved the "many windows named Unnamed" proble

I think you have it inverted. the frame won't be null in our Kepler case for the R actor. The code block should be:

if (frame == null) {
frame = new TextEditor(title, container.getDocument());
}
else {
// Set the title for the Kepler R actor
// http://bugzilla.ecoinformatics.org/show_bug.cgi?id=3187
setTitle(frame.getTitle());
}

is that reasonable?

This will not be included in the branch of ptolemy (rel70b2) we are using to build kepler 1.0
Retargeting for after 1.0.
I think Kepler 1.0 can live without the frame title text being set

Original Bugzilla ID was 3187