Project

General

Profile

Actions

Bug #5588

closed

Enter and Tab behavior has changed in parameter configuration dialog

Added by Derik Barseghian almost 12 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
interface
Target version:
Start date:
04/16/2012
Due date:
% Done:

0%

Estimated time:
Bugzilla-Id:
5588

Description

A month or so ago I noticed these changes:
- when you hit Enter when configuring an actor's parameter value, a new line is entered (and you can no longer see what you entered, just a vertical scroll bar, similar to bug#5587). It used to be that Enter just enacted the value change.
- when you hit tab, a tab is inserted. It used to be tab would move you to the next parameter's value field.

I think both of the old behaviors were better and more intuitive.

Actions #1

Updated by Daniel Crawl almost 12 years ago

I just checked and tab now moves to the next parameter's field, but enter still does not apply the new parameter value.

Note that this problem is for parameters with a line style. I checked text style and the behavior hasn't changed since the previous kepler release.

Actions #2

Updated by Christopher Brooks almost 12 years ago

The remaining issue here is that in EditParameters, if the focus is in a line entry, then hitting the enter (aka return) key does not commit the changes
and close the dialog.

It seems like this has been broken for a long time.

1) Open a model
2) Drag in a XY Plotter, double click, bringing up the Edit Parameters Window
3) The focus is on the checkbox
4) Hit enter, the window closes
5) Double click again
6) Move the focus to the legend
7) Hit enter, the window does not close

I checked Kepler-2.2, 2.3 and Ptolemy II 8.0.1 and this is how they
all work. Dan wrote:

I just checked and tab now moves to the next parameter's field, but enter still
does not apply the new parameter value.

Note that this problem is for parameters with a line style. I checked text
style and the behavior hasn't changed since the previous kepler release.

I'm confused, I can't get enter in the line style parameter to close the window.

BTW - shift-enter will add a newline to the line style parameter.

Actions #3

Updated by Christopher Brooks over 11 years ago

Patricia's fixes seem to have solved the problem of enter not closing a dialog.

I'm assigning this to Daniel for review and hopefully closing.

Actions #4

Updated by Daniel Crawl over 11 years ago

Looks good. Thanks, Patricia!

Actions #5

Updated by Redmine Admin about 11 years ago

Original Bugzilla ID was 5588

Actions

Also available in: Atom PDF